Changeset: 692478b5c7e5 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=692478b5c7e5
Modified Files:
gdk/gdk_imprints.c
Branch: default
Log Message:
Function does not return a useful value.
diffs (52 lines):
diff --git a/gdk/gdk_imprints.c b/gdk/gdk_imprints.c
--- a/gdk/gdk_imprints.c
+++ b/gdk/gdk_imprints.c
@@ -484,7 +484,7 @@ do {
\
} \
} while (0)
-static int
+static void
imprints_create(BAT *b, void *inbins, BUN *stats, bte bits,
void *imps, BUN *impcnt, cchdc_t *dict, BUN *dictcnt)
{
@@ -529,8 +529,6 @@ imprints_create(BAT *b, void *inbins, BU
*dictcnt = dcnt;
*impcnt = icnt;
-
- return 1;
}
#define FILL_HISTOGRAM(TYPE) \
@@ -819,22 +817,14 @@ BATimprints(BAT *b)
BBPunfix(smp->batCacheid);
- if (!imprints_create(b,
- imprints->bins,
- imprints->stats,
- imprints->bits,
- imprints->imps,
- &imprints->impcnt,
- imprints->dict,
- &imprints->dictcnt)) {
- GDKerror("#BATimprints: failed to create imprints");
- HEAPfree(imprints->imprints, 1);
- GDKfree(imprints->imprints);
- GDKfree(imprints);
- MT_lock_unset(&GDKimprintsLock(abs(b->batCacheid)),
- "BATimprints");
- return GDK_FAIL;
- }
+ imprints_create(b,
+ imprints->bins,
+ imprints->stats,
+ imprints->bits,
+ imprints->imps,
+ &imprints->impcnt,
+ imprints->dict,
+ &imprints->dictcnt);
assert(imprints->impcnt <= pages);
assert(imprints->dictcnt <= pages);
imprints->imprints->free = (size_t) ((char *) ((cchdc_t *)
imprints->dict + imprints->dictcnt) - imprints->imprints->base);
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list
