Changeset: 007692e0b975 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=007692e0b975
Added Files:
sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.sql
sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.stable.err
sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.stable.out
Modified Files:
sql/backends/monet5/sql_result.c
sql/test/BugTracker-2014/Tests/All
Branch: Oct2014
Log Message:
Fixed bug 3616 + added test.
diffs (164 lines):
diff --git a/sql/backends/monet5/sql_result.c b/sql/backends/monet5/sql_result.c
--- a/sql/backends/monet5/sql_result.c
+++ b/sql/backends/monet5/sql_result.c
@@ -1586,8 +1586,30 @@ mvc_export_head(backend *b, stream *s, i
for (i = 0; i < t->nr_cols; i++) {
res_col *c = t->cols + i;
- if (mnstr_write(s, c->name, strlen(c->name), 1) != 1)
- return -1;
+ if (strchr(c->name, ',') || strchr(c->name, ' ') ||
strchr(c->name , '\t')) {
+ if (mnstr_write(s, "\"", 1, 1) != 1)
+ return -1;
+ if (strchr(c->name, '"')) {
+ char *p;
+ for (p = c->name; *p; p++) {
+ if (*p == '"') {
+ if (mnstr_write(s, "\\", 1, 1)
!= 1)
+ return -1;
+ }
+ if (mnstr_write(s, p, 1, 1) != 1)
+ return -1;
+ }
+ } else {
+ if (mnstr_write(s, c->name, strlen(c->name), 1)
!= 1)
+ return -1;
+ }
+ if (mnstr_write(s, "\"", 1, 1) != 1)
+ return -1;
+ } else {
+ if (mnstr_write(s, c->name, strlen(c->name), 1) != 1)
+ return -1;
+ }
+
if (i + 1 < t->nr_cols && mnstr_write(s, ",\t", 2, 1) != 1)
return -1;
}
diff --git a/sql/test/BugTracker-2014/Tests/All
b/sql/test/BugTracker-2014/Tests/All
--- a/sql/test/BugTracker-2014/Tests/All
+++ b/sql/test/BugTracker-2014/Tests/All
@@ -52,3 +52,4 @@ fk-property-assert.Bug-3612
hexadecimal_literals.Bug-3621
orderby_column_exp.Bug-3620
case-sqrt.Bug-3627
+column-with-comma.Bug-3616
diff --git a/sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.sql
b/sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.sql
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.sql
@@ -0,0 +1,1 @@
+select 1 as "a,b", 2 as c;
diff --git
a/sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.stable.err
b/sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.stable.err
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.stable.err
@@ -0,0 +1,37 @@
+stderr of test 'column-with-comma.Bug-3616` in directory
'sql/test/BugTracker-2014` itself:
+
+
+# 17:14:20 >
+# 17:14:20 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set"
"mapi_open=true" "--set" "mapi_port=34835" "--set"
"mapi_usock=/var/tmp/mtest-28582/.s.monetdb.34835" "--set" "monet_prompt="
"--forcemito" "--set" "mal_listing=2"
"--dbpath=/ufs/sjoerd/Monet-candidate/var/MonetDB/mTests_sql_test_BugTracker-2014"
"--set" "mal_listing=0" "--set" "embedded_r=yes"
+# 17:14:20 >
+
+# builtin opt gdk_dbpath =
/ufs/sjoerd/Monet-candidate/var/monetdb5/dbfarm/demo
+# builtin opt gdk_debug = 0
+# builtin opt gdk_vmtrim = no
+# builtin opt monet_prompt = >
+# builtin opt monet_daemon = no
+# builtin opt mapi_port = 50000
+# builtin opt mapi_open = false
+# builtin opt mapi_autosense = false
+# builtin opt sql_optimizer = default_pipe
+# builtin opt sql_debug = 0
+# cmdline opt gdk_nr_threads = 0
+# cmdline opt mapi_open = true
+# cmdline opt mapi_port = 34835
+# cmdline opt mapi_usock = /var/tmp/mtest-28582/.s.monetdb.34835
+# cmdline opt monet_prompt =
+# cmdline opt mal_listing = 2
+# cmdline opt gdk_dbpath =
/ufs/sjoerd/Monet-candidate/var/MonetDB/mTests_sql_test_BugTracker-2014
+# cmdline opt mal_listing = 0
+# cmdline opt embedded_r = yes
+# cmdline opt gdk_debug = 536870922
+
+# 17:14:21 >
+# 17:14:21 > "mclient" "-lsql" "-ftest" "-Eutf-8" "-i" "-e"
"--host=/var/tmp/mtest-28582" "--port=34835"
+# 17:14:21 >
+
+
+# 17:14:21 >
+# 17:14:21 > "Done."
+# 17:14:21 >
+
diff --git
a/sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.stable.out
b/sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.stable.out
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2014/Tests/column-with-comma.Bug-3616.stable.out
@@ -0,0 +1,67 @@
+stdout of test 'column-with-comma.Bug-3616` in directory
'sql/test/BugTracker-2014` itself:
+
+
+# 17:14:20 >
+# 17:14:20 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set"
"mapi_open=true" "--set" "mapi_port=34835" "--set"
"mapi_usock=/var/tmp/mtest-28582/.s.monetdb.34835" "--set" "monet_prompt="
"--forcemito" "--set" "mal_listing=2"
"--dbpath=/ufs/sjoerd/Monet-candidate/var/MonetDB/mTests_sql_test_BugTracker-2014"
"--set" "mal_listing=0" "--set" "embedded_r=yes"
+# 17:14:20 >
+
+# MonetDB 5 server v11.19.8 (hg id: 682d22ac9255+)
+# This is an unreleased version
+# Serving database 'mTests_sql_test_BugTracker-2014', using 8 threads
+# Compiled for x86_64-unknown-linux-gnu/64bit with 64bit OIDs dynamically
linked
+# Found 15.590 GiB available main-memory.
+# Copyright (c) 1993-July 2008 CWI.
+# Copyright (c) August 2008-2014 MonetDB B.V., all rights reserved
+# Visit http://www.monetdb.org/ for further information
+# Listening for connection requests on mapi:monetdb://madrid.ins.cwi.nl:34835/
+# Listening for UNIX domain connection requests on
mapi:monetdb:///var/tmp/mtest-28582/.s.monetdb.34835
+# MonetDB/GIS module loaded
+# MonetDB/SQL module loaded
+# MonetDB/R module loaded
+
+Ready.
+# SQL catalog created, loading sql scripts once
+# loading sql script: 09_like.sql
+# loading sql script: 10_math.sql
+# loading sql script: 11_times.sql
+# loading sql script: 12_url.sql
+# loading sql script: 13_date.sql
+# loading sql script: 14_inet.sql
+# loading sql script: 15_querylog.sql
+# loading sql script: 16_tracelog.sql
+# loading sql script: 19_cluster.sql
+# loading sql script: 20_vacuum.sql
+# loading sql script: 21_dependency_functions.sql
+# loading sql script: 22_clients.sql
+# loading sql script: 23_skyserver.sql
+# loading sql script: 24_zorder.sql
+# loading sql script: 25_debug.sql
+# loading sql script: 26_sysmon.sql
+# loading sql script: 39_analytics.sql
+# loading sql script: 40_geom.sql
+# loading sql script: 40_json.sql
+# loading sql script: 41_jsonstore.sql
+# loading sql script: 45_uuid.sql
+# loading sql script: 46_gsl.sql
+# loading sql script: 75_storagemodel.sql
+# loading sql script: 80_statistics.sql
+# loading sql script: 80_udf.sql
+# loading sql script: 85_bam.sql
+# loading sql script: 90_generator.sql
+# loading sql script: 99_system.sql
+
+# 17:14:21 >
+# 17:14:21 > "mclient" "-lsql" "-ftest" "-Eutf-8" "-i" "-e"
"--host=/var/tmp/mtest-28582" "--port=34835"
+# 17:14:21 >
+
+#select 1 as "a,b", 2 as c;
+% .L, .L # table_name
+% "a,b", c # name
+% tinyint, tinyint # type
+% 1, 1 # length
+[ 1, 2 ]
+
+# 17:14:21 >
+# 17:14:21 > "Done."
+# 17:14:21 >
+
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list
