aaron.ballman added a comment.

The docs do not look correct to me. For instance, I don't see any changes to 
the `hasDeclaration()` documentation for the newly supported type. There also 
appear to be a bunch of unrelated changes in the generated HTML.



================
Comment at: clang/docs/LibASTMatchersReference.html:3292-3294
+  [x containsString:@"h"];
 but not
+  [NSString stringWithFormat:@"format"];
----------------
I thought these changes already went in as a separate commit? These are 
unrelated to the patch.


================
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:44
 #include "clang/AST/Expr.h"
+#include "clang/AST/ExprObjC.h"
 #include "clang/AST/ExprCXX.h"
----------------
This list should remain sorted alphabetically.


https://reviews.llvm.org/D49701



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to