Or make operator bool explicit
On Mon, Jul 23, 2018, 13:55 Ilya Biryukov via Phabricator <
revi...@reviews.llvm.org> wrote:
> ilya-biryukov accepted this revision.
> ilya-biryukov added a comment.
> This revision is now accepted and ready to land.
>
> Scary....
> Definitely LGTM!
>
>
>
> ================
> Comment at: clangd/index/Index.h:45
>
> - operator bool() const { return !FileURI.empty(); }
> + explicit operator bool() const { return !FileURI.empty(); }
> + bool operator==(const SymbolLocation& Loc) const {
> ----------------
> Maybe we should go even further and replace this with an `isValid` method?
> Conversion ops are confusing.
>
>
> Repository:
> rCTE Clang Tools Extra
>
> https://reviews.llvm.org/D49657
>
>
>
>
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
