0x8000-0000 added inline comments.
================ Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:23 + +const char DefaultIgnoredValues[] = "0;1;2;10;100;"; + ---------------- aaron.ballman wrote: > lebedev.ri wrote: > > aaron.ballman wrote: > > > Why 2, 10, and 100? > > These really should be a config option. > These are the default values for the config option. I think 0 and 1 make a > lot of sense to have in the default list given how prevalent they are in real > world code. But the other three seem to be used far less often. > > I think if we wanted to have any values other than 0 and 1 (and perhaps -1) > as defaults, I'd want to see some data on large amounts of code to justify > anything else. No need for -1, as it is covered by 1, plus unary operator. I know 100 is used often for converting percentages. 10 is used for number parsing (yes, many people still do that by hand instead of libraries). But this is the configuration - and I'm ok with reverting to 0 and 1 as I had originally. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
