ioeric added a comment.

In https://reviews.llvm.org/D48903#1159046, @simark wrote:

> In https://reviews.llvm.org/D48903#1159023, @ioeric wrote:
>
> > Would you mind reverting this patch for now so that we can come up with a 
> > solution to address those use cases?
> >
> > Sorry again about missing the discussion earlier!
>
>
> Of course, feel free to revert if needed (I'm not sure how to do that).  Are 
> you able to come up with a test case that covers the use case you mention?


Thanks! I'll try to come up with a smaller test case asap.

The virtual file support in `FileManager` is totally confusing and full of 
traps (when used with VFS). I really feel we should replace it with 
InMemoryFileSystem at some point :(


Repository:
  rC Clang

https://reviews.llvm.org/D48903



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to