thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land.
lgtm assuming you ran this on some large code base to make sure it doesn't have false positives. ================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:659 +def warn_suspicious_sizeof_memset : Warning< + "%select{'size' argument to memset is '0'|setting buffer to a 'sizeof' expression}0; did you mean to transpose the last two arguments?">, + InGroup<MemsetTransposedArgs>; ---------------- nit: stay below 80 columns https://reviews.llvm.org/D49112 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits