sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
I like this idea, of course hard to know how it will affect all practical cases.
Is it easy to get have internal stats on how many wins/losses this has?
================
Comment at: clangd/CodeComplete.cpp:596
+ // FIXME: in case there is no future sema completion callback after the
+ // recovery mode, we migth still want to provide some results.
+ if (Context.getKind() == CodeCompletionContext::CCC_Recovery) {
----------------
might
================
Comment at: clangd/CodeComplete.cpp:596
+ // FIXME: in case there is no future sema completion callback after the
+ // recovery mode, we migth still want to provide some results.
+ if (Context.getKind() == CodeCompletionContext::CCC_Recovery) {
----------------
sammccall wrote:
> might
This might also be a case where we can trial identifier-based completion.
(Eventually I think we'd want it in other contexts too)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49175
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
