xazax.hun added a comment.

Thanks! The changes look good, I forgot to mark one double lookup though in my 
previous review.



================
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:121
+      if (State->contains<RawPtrMap>(ObjRegion)) {
+        NewSet = *State->get<RawPtrMap>(ObjRegion);
+        if (NewSet.contains(RawPtr.getAsSymbol()))
----------------
Oh, there is also a double lookup here, sorry I did not spot it in the initial 
review.


https://reviews.llvm.org/D49057



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to