rjmccall added inline comments.
================
Comment at: test/SemaObjC/property-in-class-extension-1.m:18
-@property (assign, readonly) NSString* changeMemoryModel; // expected-note
{{property declared here}}
+@property (unsafe_unretained, readonly) NSString* changeMemoryModel; //
expected-note {{property declared here}}
----------------
QF5690 wrote:
> rjmccall wrote:
> > Whoa, why is this test case using `-Weverything`? That seems unnecessarily
> > fragile.
> Do you think it should be relaxed only to warnings that are appearing here?
Yeah, tests should generally only be testing specific categories. Opt-out
warnings are different, of course, but it's understood that adding a new
opt-out warning is an ambitious change.
Repository:
rC Clang
https://reviews.llvm.org/D44539
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
