martong added inline comments.

================
Comment at: lib/AST/ASTImporter.cpp:2559
                                            D->isImplicit());
+    ToFunction->setRangeEnd(Importer.Import(D->getLocEnd()));
   } else if (auto *FromConversion = dyn_cast<CXXConversionDecl>(D)) {
----------------
Why don't we need to call the `setRangeEnd()` when e.g. we create a 
`CXXMethodDecl` or a `CXXConversionDecl`? Couldn't we just call this after all 
these branches (at line 2587)?


Repository:
  rC Clang

https://reviews.llvm.org/D48941



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to