ilya-biryukov added a comment.
Generally LG, just one comment.
================
Comment at: lib/Sema/SemaCodeComplete.cpp:3744
AddMacroResults(PP, Results, false, PreferredTypeIsPointer);
- HandleCodeCompleteResults(this, CodeCompleter,
- CodeCompletionContext(CodeCompletionContext::CCC_Expression,
----------------
`ResultsBuilder`'s constructor accepts a `CodeCompletionContext`. Can we pass
in the context with `PreferedType` there instead of reconstructing it later?
To make sure we don't miss other things (incl. any future additions) that
`ResultsBuilder` puts into the context.
Repository:
rC Clang
https://reviews.llvm.org/D48917
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
