klimek added inline comments.
================
Comment at: lib/Basic/VirtualFileSystem.cpp:328
void OverlayFileSystem::pushOverlay(IntrusiveRefCntPtr<FileSystem> FS) {
+ // FIXME: OverlayFS containing another one in its stack could be flattened.
FSList.push_back(FS);
----------------
ilya-biryukov wrote:
> I generally agree that it might be useful, but given that we can't use
> `dynamic_cast` in LLVM code addressing this `FIXME` is probably not worth the
> effort.
>
> And this patch is probably not the right place to add this comment, since it
> doesn't change `OverlayFileSystem` in any way.
We can dyn_cast in LLVM code. It incurs some cost on the class hierarchy, but
it's possible.
https://reviews.llvm.org/D45094
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
