simon_tatham added a comment.

As I mentioned on llvm-dev, this is an unfinished draft. I'm interested in 
review comments, but I already know things like 'needs more comments / tests / 
careful error handling' :-)

Some 'known unknowns':

- I'm caching the results of every directory scan, to save effort when more 
include files are needed from the same directory. That assumes that the 
lifetime of this filesystem object is short enough that we don't have to worry 
about new files appearing in directories we've already looked at, which seems 
like a reasonable assumption in an ordinary compile, but I don't know if the 
same filesystem abstraction might be used in completely different contexts 
elsewhere in the LLVM ecosystem and have a longer lifetime. Do I need to take a 
lot more care with my cache persistence?
- I was wondering if it might be worth having a second command-line option, to 
turn on only the case-insensitivity and not the backslash-separator tolerance 
(e.g. for use on source code developed for Mac rather than Windows).
- The option name is the first one that sprang to mind and I'm expecting 
someone will probably suggest a better one.


Repository:
  rC Clang

https://reviews.llvm.org/D48626



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to