[PATCH] D48506: Fix for Crash in nested name specifier decltype

[Balaji Iyer via Phabricator via cfe-commits]

bviyer created this revision.
bviyer added reviewers: rsmith, arphaman.

There was a crash when qualtype is null in the function 
Sema::ActOnCXXNestedNameSpecifierDecltype. If it is null then just return 
without processing it further.


Repository:
  rC Clang

https://reviews.llvm.org/D48506

Files:
  lib/Sema/SemaCXXScopeSpec.cpp
  test/SemaCXX/qualtype-null-check.cpp


Index: test/SemaCXX/qualtype-null-check.cpp
===================================================================
--- /dev/null
+++ test/SemaCXX/qualtype-null-check.cpp
@@ -0,0 +1,6 @@
+// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s
+struct A
+{
+    bool x{&decltype(foo)::foo}; // expected-error {{reference to non-static 
member function must be called}}
+    void foo(int);
+};
Index: lib/Sema/SemaCXXScopeSpec.cpp
===================================================================
--- lib/Sema/SemaCXXScopeSpec.cpp
+++ lib/Sema/SemaCXXScopeSpec.cpp
@@ -846,6 +846,8 @@
   assert(DS.getTypeSpecType() == DeclSpec::TST_decltype);
 
   QualType T = BuildDecltypeType(DS.getRepAsExpr(), DS.getTypeSpecTypeLoc());
+  if (T.getTypePtrOrNull() == nullptr)
+      return true;
   if (!T->isDependentType() && !T->getAs<TagType>()) {
     Diag(DS.getTypeSpecTypeLoc(), diag::err_expected_class_or_namespace) 
       << T << getLangOpts().CPlusPlus;



Index: test/SemaCXX/qualtype-null-check.cpp
===================================================================
--- /dev/null
+++ test/SemaCXX/qualtype-null-check.cpp
@@ -0,0 +1,6 @@
+// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s
+struct A
+{
+    bool x{&decltype(foo)::foo}; // expected-error {{reference to non-static member function must be called}}
+    void foo(int);
+};
Index: lib/Sema/SemaCXXScopeSpec.cpp
===================================================================
--- lib/Sema/SemaCXXScopeSpec.cpp
+++ lib/Sema/SemaCXXScopeSpec.cpp
@@ -846,6 +846,8 @@
   assert(DS.getTypeSpecType() == DeclSpec::TST_decltype);
 
   QualType T = BuildDecltypeType(DS.getRepAsExpr(), DS.getTypeSpecTypeLoc());
+  if (T.getTypePtrOrNull() == nullptr)
+      return true;
   if (!T->isDependentType() && !T->getAs<TagType>()) {
     Diag(DS.getTypeSpecTypeLoc(), diag::err_expected_class_or_namespace) 
       << T << getLangOpts().CPlusPlus;

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits