sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clangd/CodeCompletionStrings.cpp:172
// get this declaration, so we don't show documentation in that case.
if (Result.Kind != CodeCompletionResult::RK_Declaration)
return "";
----------------
while here, should this be if (Result.Declaration)? I make this mistake a lot...
================
Comment at: clangd/CodeCompletionStrings.cpp:177
return "";
+ if (llvm::isa<NamespaceDecl>(Decl)) {
+ // Namespaces often have too many redecls for any particular redecl comment
----------------
nit: canRequestComment looks a little expensive, hoist above that?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48211
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
