ilya-biryukov added a comment.

Overall LG. It would be nice to mention somewhere that we since we bundle 
overloads client-side we might run into weird side-effects (e.g. return less 
completion items than the specified limit) in case the index returns too many 
non-bundled.



================
Comment at: clangd/tool/ClangdMain.cpp:62
 
+// TODO: also support "plain" style where signatures are always omitted.
+enum CompletionStyleFlag {
----------------
NIT: maybe use FIXME to be consistent with the rest of clangd?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D47957



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to