Meinersbur marked an inline comment as done. Meinersbur added a comment. In https://reviews.llvm.org/D48100#1132208, @aaron.ballman wrote:
> Can you also simplify `hasSameOverloadableAttrs()` in ASTReaderDecl.cpp > similar to what you did in SemaOverload.cpp (the copy seems spurious)? Changed `hasSameOverloadableAttrs`. Apart to the comment about that the reversal of attributes being unimportant, it does not seem related to the new attribute order, though. I made the iteration over `AEnableIfAttrs` and `BEnableIfAttrs` symmetric (and IMHO easier to understand), which unfortunately is not possible with a foreach (there are also a zip-iterators, but I am not sure how to check for different lengths without `std::distance` iterating over it separately). I can change `compareEnableIfAttrs` as well on request. Repository: rC Clang https://reviews.llvm.org/D48100 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
