george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed.
LGTM with a nit on a test name. ================ Comment at: test/Analysis/pr37646.c:1 +// REQUIRES: z3 +// RUN: %clang_analyze_cc1 -triple x86_64-apple-darwin9 -analyzer-checker=core -analyzer-store=region -analyzer-constraints=z3 -verify %s ---------------- The tests are already quite messy, but adding a new file per each bug seems excessive. Could we take your test and `test/Analysis/apsint.c` and combine them into e.g. `z3_apsint_encoding.c` ? (also adding a link to bugzilla) Repository: rC Clang https://reviews.llvm.org/D47617 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
