ebevhan added inline comments.
================
Comment at: test/Sema/address_spaces.c:17
int *_AS1 _AS2 *Z; // expected-error {{multiple address spaces specified
for type}}
+ int *_AS1 _AS1 *M;
----------------
bader wrote:
> I think it might be valuable to give a warning or remark to user.
> Using the same address space qualifier multiple times is not something OpenCL
> C developers are supposed to do.
>
The test is obviously a bit contrived, but it could happen by mistake, or as a
result of some typedef or macro combination. It also cannot go wrong, so
there's no harm in it happening.
I see your point, though. A warning feels like a bit much, so I'm not sure what
else to use. A note?
Repository:
rC Clang
https://reviews.llvm.org/D47630
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
