sammccall accepted this revision. sammccall added a comment. Thanks, LG!
================ Comment at: clangd/CodeComplete.h:86 +// For index-based completion, we only want: +// * symbols in namespaces or translation unit scopes (e.g. no class ---------------- nit: want -> consider? ================ Comment at: clangd/CodeComplete.h:94 +// lookup rules. +bool isIndexedForCodeCompletion(const NamedDecl &ND, ASTContext &ASTCtx); } // namespace clangd ---------------- A little more context: "// Other symbols still appear in the index for other purposes, like workspace/symbols or textDocument/definition, but are not used for code completion" ================ Comment at: clangd/index/SymbolCollector.h:22 +/// \brief Collect symbols from an AST. +/// It collects most symbols except: +/// - Implicit symbols ---------------- nit: can you change "symbols" here to "declarations"? currently we rely a bit too heavily on the user knowing what "symbol" means Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44954 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
