efriedma added a comment.

If you don't want to spend too much time on C++, fine; could you add a short 
Objective-C test instead to make sure the trivially-copyable checks are working?

What are the changes to Sema::RequireCompleteTypeImpl supposed to do?



================
Comment at: test/Sema/atomic-type.c:30
+  int i;
+  (void)__atomic_load(addr, &i, 5); // expected-error {{address argument to 
atomic operation must be a pointer to a trivially-copyable type ('_Atomic(void) 
*' invalid)}}
+  (void)__c11_atomic_load(addr, 5); // expected-error {{invalid use of 
incomplete type 'void'}}
----------------
This error message is terrible; yes, technically 'void' isn't trivially 
copyable, but that isn't really helpful.


https://reviews.llvm.org/D46112



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to