rnk added a comment.

I think this would be easy to unit test in 
llvm/unittests/Support/CommandLine.cpp. We'd just check that the filename is 
"SupportTests.exe" on Windows and the path is relative after calling this, I 
guess. Right? Look at how ProgramTest.cpp does this to get a reasonable argv0:

  sys::fs::getMainExecutable(TestMainArgv0, &ProgramTestStringArg1);

In https://reviews.llvm.org/D47578#1117790, @takuto.ikuta wrote:

> In https://reviews.llvm.org/D47578#1117760, @amccarth wrote:
>
> > I was under the impression that some tools rely on the fact that arg[0] is 
> > always expanded to an absolute path.  Does this work with lldb and its test 
> > suite?
>
>
> I tried, but there is no check-lldb target. Can I ask you what is the target 
> name to run lldb test suite?


The LLDB test suite isn't in very good shape on Windows. It is complicated to 
set up and build, I don't want to block this fix on @takuto.ikuta setting up 
that build environment. This is a Windows-only change, and I believe it makes 
it more consistent with Linux, so as long as check-llvm, check-clang, and 
check-lld pass, this should be relatively safe.


https://reviews.llvm.org/D47578



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to