thakis added a comment.

I did test this locally before sending it out, and the -resource-dir arg passed 
to cc1 is relative with this patch:

  $ bin/clang-cl -no-canonical-prefixes -c test.cc -###
  clang version 7.0.0 
  Target: x86_64-pc-windows-msvc
  Thread model: posix
  InstalledDir: bin
   "bin/clang-cl" "-cc1" "-triple" "x86_64-pc-windows-msvc19.11.0" "-emit-obj" 
"-mrelax-all" "-mincremental-linker-compatible" "-disable-free" 
"-main-file-name" "test.cc" "-mrelocation-model" "pic" "-pic-level" "2" 
"-mthread-model" "posix" "-relaxed-aliasing" "-fmath-errno" "-masm-verbose" 
"-mconstructor-aliases" "-munwind-tables" "-target-cpu" "x86-64" "-mllvm" 
"-x86-asm-syntax=intel" "-D_MT" "-flto-visibility-public-std" 
"--dependent-lib=libcmt" "--dependent-lib=oldnames" "-stack-protector" "2" 
"-fms-volatile" "-fdiagnostics-format" "msvc" "-dwarf-column-info" 
"-debugger-tuning=gdb" "-target-linker-version" "305" 
"-momit-leaf-frame-pointer" "-coverage-notes-file" 
"/Users/thakis/src/llvm-mono/test.gcno" "-resource-dir" "lib/clang/7.0.0" 
"-internal-isystem" "lib/clang/7.0.0/include" "-fdeprecated-macro" 
"-fdebug-compilation-dir" "/Users/thakis/src/llvm-mono" "-ferror-limit" "19" 
"-fmessage-length" "254" "-fno-use-cxa-atexit" "-fms-extensions" 
"-fms-compatibility" "-fms-compatibility-version=19.11" "-std=c++14" 
"-fdelayed-template-parsing" "-fobjc-runtime=gcc" "-fseh-exceptions" 
"-fdiagnostics-show-option" "-fcolor-diagnostics" "-o" "test.obj" "-x" "c++" 
"test.cc"

driver.cpp handles this directly here 
http://llvm-cs.pcc.me.uk/tools/clang/tools/driver/driver.cpp#54 and here 
http://llvm-cs.pcc.me.uk/tools/clang/tools/driver/driver.cpp#390 -- what's the 
problem with the InitLLVM call you point at?


https://reviews.llvm.org/D47480



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to