lebedev.ri added a comment. LGTM, but i'm quite unfamiliar with this area of the code, so please wait for someone else to accept :)
================ Comment at: lib/Driver/Compilation.cpp:276-277 + + // Temporary files added by diagnostics should be kept. + SaveTempsEnabled = true; } ---------------- dstenb wrote: > lebedev.ri wrote: > > Is there a test that breaks without this? > Yes, the following tests fail: > > - Driver/crash-report-modules.m > - Driver/crash-report-spaces.c > - Driver/crash-report-header.h > - Driver/crash-report.c > - Modules/crash-vfs-path-emptydir-entries.m > - Modules/crash-vfs-path-symlink-topheader.m > - Modules/crash-vfs-path-symlink-component.m > - Modules/crash-vfs-path-traversal.m > - Modules/crash-vfs-relative-overlay.m > - Modules/crash-vfs-umbrella-frameworks.m > > due to the preprocessed files for the crash diagnostics having been removed. Ok, good. https://reviews.llvm.org/D45686 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
