george.karpenkov added a comment.

@NoQ I'm really wary of magic numbers.

- We should expose it through an analyzer-config flag. We already do so for the 
budget.
- We should probably have both positive and negative tests. What scenarios 
_stop_ working after the threshold is decreased? [point 1 is required to be 
able to test that]
- Finally, do we understand where the slowdown comes from? If it comes from 
attempted rearrangements due to https://reviews.llvm.org/rC329780 I think we 
should roll that back instead.


Repository:
  rC Clang

https://reviews.llvm.org/D47155



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to