bruno added inline comments.
================ Comment at: test/Preprocessor/headermap-rel.c:2-3 // This uses a headermap with this entry: // Foo.h -> Foo/Foo.h ---------------- dexonsmith wrote: > Should we delete this comment now that the header map is human-readable? Sure! ================ Comment at: test/Preprocessor/headermap-rel.c:6 +// RUN: rm -f %t.hmap +// RUN: hmaptool write %S/Inputs/headermap-rel/foo.hmap.json %t.hmap +// RUN: %clang_cc1 -E %s -o %t.i -I %t.hmap -F %S/Inputs/headermap-rel ---------------- dexonsmith wrote: > Should there be some sort of `REQUIRES:` clause for using `hmaptool`? Not really needed, `hmaptool` is setup to work just like `clang-rename` and others, it will always be available to be used by lit. Additionally, it's not importing any module that isn't in the python standard library. https://reviews.llvm.org/D46485 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
