martong added inline comments.

================
Comment at: lib/AST/ASTImporter.cpp:6776
+  // been invalidated to avoid repeatedly calling this.
+  ToContext.invalidateParents();
+
----------------
Can an `Expr` has a parent too? If yes, why not invalidate the parents in 
`Import(Expr*)` ?
I am also a bit concerned to call the invalidation during the import of all 
`Stmt` (and possible during the import of `Expr`s too).
Isn't it enough to invalidate only during `Import(Decl*)`?


https://reviews.llvm.org/D46940



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to