rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
LGTM with a fix (and test) for pointer-to-array-of-dynamic-class-type handling. ================ Comment at: lib/CodeGen/CGBuiltin.cpp:936-938 + const auto *Record = Ty->getAsCXXRecordDecl(); + if (!Record || !Seen.insert(Record).second) + return false; ---------------- I think you also need to recurse through array types (use `Ty->getBaseElementTypeUnsafe()->getAsCXXRecordDecl()` or similar). https://reviews.llvm.org/D40218 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
