tejohnson added inline comments.
================ Comment at: test/CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll:14 +; RUN: %clang -O2 -x ir %t.o -fthinlto-index=%t.thinlto.bc -fsave-optimization-record -fdiagnostics-show-hotness -o %t2.o -c +; RUN: cat %t2.opt.yaml.thin.0.yaml | FileCheck %s -check-prefix=YAML + ---------------- pcc wrote: > This file isn't named correctly according to the `-foptimization-record-file` > flag, right? Looks like the easy fix would be to pass -1 as the task > identifier to thinBackend, but it would probably be worth looking more > closely at some point at how we name these extra files in LTO. I realized after cleaning out old test outputs that this causes an issue with the handling of save-temps for ThinLTO distributed backends. Previously they were adding the task ID of "0", and this became unsigned -1 after this change. I sent an LLVM patch D46488 to change that so no Task ID is added to the path if it is -1, and updated the test in this clang patch. Repository: rC Clang https://reviews.llvm.org/D46464 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
