thakis added inline comments.
================ Comment at: test/Frontend/plugins.c:7 + +// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns %s | FileCheck -check-prefix=CHECK-COMPLETION-WITHOUT-PLUGINS %s +// REQUIRES: plugins, examples ---------------- nik wrote: > Should this test rather go into test/Index because of the c-index-test? Yes, I think so. ================ Comment at: test/Frontend/plugins.c:8 +// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns %s | FileCheck -check-prefix=CHECK-COMPLETION-WITHOUT-PLUGINS %s +// REQUIRES: plugins, examples + ---------------- nik wrote: > Note that I actually have problems with this REQUIRES line. I use > -DCLANG_BUILD_EXAMPLES and -DDBUILD_SHARED_LIBS=ON and this test (and the one > above too) is skipped/unsupported. What else do I need? > > Note that If I remove this line, the test is run - apparently the > requirements are fulfilled, but not properly detected. I guess this is set up > issue on my local machine? Are you on Windows? plugins is set here: http://llvm-cs.pcc.me.uk/tools/clang/test/lit.cfg.py#73 enable_shared here: http://llvm-cs.pcc.me.uk/tools/clang/test/lit.site.cfg.py.in#25 from here: http://llvm-cs.pcc.me.uk/cmake/modules/AddLLVM.cmake#1193 So my guess is you need to set LLVM_ENABLE_PLUGINS (and that you are on Windows), but I haven't tried it. Repository: rC Clang https://reviews.llvm.org/D46050 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
