shuaiwang added a comment. In https://reviews.llvm.org/D45702#1086250, @aaron.ballman wrote:
> In https://reviews.llvm.org/D45702#1085890, @shuaiwang wrote: > > > In https://reviews.llvm.org/D45702#1085224, @aaron.ballman wrote: > > > > > > Have you run this over any large code bases to see whether the check > > > > triggers in practice? > > > > > > I'm still curious about this, btw. > > > > > > Yes it triggers in Google's code base. > > > Were there any false positives that you saw? From randomly checking several triggerings no I didn't find any false positives. I feel the check should be pretty safe in terms of false positives because we only trigger on configured types. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45702 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
