aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
Missing Sema tests that the attribute only appertains to functions, accepts no
arguments, etc.
================
Comment at: include/clang/Basic/Attr.td:1494
+def NoStackProtector : InheritableAttr {
+ let Spellings = [GCC<"no_stack_protector">];
+ let Subjects = SubjectList<[Function]>;
----------------
This is not a GCC attribute, so this should use the Clang spelling.
However, why spell the attribute this way rather than use the GCC spelling
(`optimize("no-stack-protector")`?
================
Comment at: include/clang/Basic/Attr.td:1496
+ let Subjects = SubjectList<[Function]>;
+ let Documentation = [Undocumented];
+}
----------------
No new undocumented attributes, please.
Repository:
rC Clang
https://reviews.llvm.org/D46300
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
