vsapsai added a comment.

I plan to look into cleaning this up and addressing the review comments.

Need to check if `DepCollectorPPCallbacks` has to be updated too.



================
Comment at: lib/Frontend/DependencyFile.cpp:302
+                 SrcMgr::CharacteristicKind FileType) {
+  AddFilename(llvm::sys::path::remove_leading_dotslash(SkippedFile.getName()));
+}
----------------
I suspect we need to call `FileMatchesDepCriteria` here too.


https://reviews.llvm.org/D30881



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to