rsmith added a comment.

In https://reviews.llvm.org/D46218#1081933, @rjmccall wrote:

> Have you checked whether we do the right thing with `#pragma pack` on MSVC?


Great question, I hadn't. Both MSVC and GCC treat `#pragma pack` as applying to 
base classes, which is what we do with/without this patch. I'll add some tests 
to cover that.


Repository:
  rC Clang

https://reviews.llvm.org/D46218



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D46218: P... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D462... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D462... John McCall via Phabricator via cfe-commits
    • [PATCH] D462... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D462... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D462... Paul Robinson via Phabricator via cfe-commits
    • [PATCH] D462... Richard Smith - zygoloid via Phabricator via cfe-commits

Reply via email to