[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added inline comments.


================
Comment at: lib/Sema/SemaExpr.cpp:3056
+      if (LangOpts.OpenCL)
+          ResTy = Context.getAddrSpaceQualType(ResTy, LangAS::opencl_constant);
       ResTy = Context.getConstantArrayType(ResTy, LengthI, ArrayType::Normal,
----------------
Nitpick: local indent style is 2 spaces.


================
Comment at: test/SemaOpenCL/predefind-expr.cl:1
+// RUN: %clang_cc1 %s -verify
+
----------------
predefind-expr.cl -> predefined_expr.cl

Also please indent the function body.


https://reviews.llvm.org/D46049



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits