craig.topper added a comment.

I see that gcc implements all of this with wrappers around inline assembly. Any 
reason we couldn't just do that?



================
Comment at: lib/Headers/pconfigintrin.h:31
+
+#define MKTME_KEY_PROGRAM 0x00000001
+
----------------
This doesn't match the name used by gcc. It also needs to start with 
underscores since all names without underscores belong to user code.


================
Comment at: lib/Headers/sgxintrin.h:52
+}
+
+#endif
----------------
You need to undef __DEFAULT_FN_ATTRS


https://reviews.llvm.org/D44387



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to