craig.topper added inline comments.

================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8425
+  llvm::Type *VTy = llvm::VectorType::get(QTy, N);
+  llvm::Type *BTy = llvm::VectorType::get(CGF.Builder.getInt8Ty(), N * 8);
+  SmallVector<uint32_t, 8> ShuffleMask;
----------------
Is this not a dead variable now?


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8426
+  llvm::Type *BTy = llvm::VectorType::get(CGF.Builder.getInt8Ty(), N * 8);
+  SmallVector<uint32_t, 8> ShuffleMask;
+  ShuffleMask.resize(N);
----------------
SmallVector<uint32_t, 8> ShuffleMask(N);

Then you don't need the resize call.


https://reviews.llvm.org/D45722



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to