ahatanak added a comment.

x.



================
Comment at: lib/CodeGen/CGCall.cpp:3069
+  if (hasAggregateEvaluationKind(type) &&
+      getContext().isParamDestroyedInCallee(type)) {
+    EHScopeStack::stable_iterator cleanup =
----------------
rjmccall wrote:
> I wonder if this is something we should be taking from the CGFunctionInfo 
> instead.  It does seem plausible that it could vary, e.g. according to the 
> calling convention.  But maybe that's something we can handle in a separate 
> patch?
I assume you are talking about the call to isParamDestroyedInCallee? If so, 
yes, I think we can discuss it in a separate patch. I have plans to clean up 
the way ParamDestroyedInCallee is handled in Sema and IRGen.


Repository:
  rC Clang

https://reviews.llvm.org/D45382



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to