hokein added inline comments. Herald added a subscriber: jkorous.
================ Comment at: clangd/FindSymbols.cpp:117 + } + auto Path = URI::resolve(*Uri); + if (!Path) { ---------------- The current URI scheme (`file`, `test`) works fine without `HintPath` because they don't use it, but for some custom URI schemes, they might rely on the `HintPath`(e.g. the path of current main file) to resolve the absolute path correctly. Maybe add a FIXME here? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits