paulsemel added a comment. In https://reviews.llvm.org/D45615#1067068, @aaron.ballman wrote:
> In https://reviews.llvm.org/D45615#1066975, @paulsemel wrote: > > > In https://reviews.llvm.org/D45615#1066973, @lebedev.ri wrote: > > > > > Tests? > > > > > > I can do this. But currently, I am not testing the formats in the tests.. > > > Now might be a good time to test that, because this patch almost added a bug > by missing the length modifiers. Also, all patches should come with some > tests to demonstrate the behavioral differences from the current trunk. Sure. I will do another review for the existing format testing, and then go back to this one to finish the type handling ! Repository: rC Clang https://reviews.llvm.org/D45615 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
