ilya-biryukov added inline comments.
================ Comment at: unittests/clangd/FileIndexTests.cpp:218 + EXPECT_EQ(Sym.CompletionLabel, "vector<class Ty>"); + EXPECT_EQ(Sym.CompletionSnippetInsertText, "vector<${1:class Ty}>"); + SeenVector = true; ---------------- sammccall wrote: > If snippets are off, we'll get "vector", not "vector<>", right? > > (Probably no need to test this explicitly, but I just want to be sure) Yes, that's exactly the case. Testing doesn't hurt too, added a test. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45482 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits