smeenai added a comment. This LGTM given that Eric accepted your previous change. I'm happy to accept it in a day or two if he hasn't gotten the chance to take a look by then.
================ Comment at: libcxx/CMakeLists.txt:101 +if (FUCHSIA) + set(ABI_VERSION_DEFAULT 2) +else() ---------------- I prefer `DEFAULT_ABI_VERSION` to `ABI_VERSION_DEFAULT` Repository: rCXX libc++ https://reviews.llvm.org/D45529 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits