george.burgess.iv added a comment.

Thanks for the feedback!

> and I suspect that your interest in this check is also related to android?

Yup :)

> Alternatively, if there are other checks specific to the GNU C library 
> planned, we could add a new module for it.

I have nothing planned, so I'm happy with this sitting under `android-`.



================
Comment at: 
docs/clang-tidy/checks/bugprone-comparison-in-temp-failure-retry.rst:7
+Diagnoses comparisons that appear to be incorrectly placed in the argument to
+the ``TEMP_FAILURE_RETRY`` macro. Having such a use is incorrect in the vast
+majority of cases, and will often silently defeat the purpose of the
----------------
alexfh wrote:
> The documentation should provide some context w.r.t what the 
> TEMP_FAILURE_RETRY macro is and where it comes from (maybe also link to its 
> documentation).
Added a paragraph after this one.


https://reviews.llvm.org/D45059



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to