ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a small nit.
Really excited about this landing!
================
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:353
+ }
+ Best = Candidate.first;
+ BestPreferred = Preferred;
----------------
Maybe put these fields into `struct Candidate {}`?
The code would, arguably, be easier to read. Up to you.
Repository:
rC Clang
https://reviews.llvm.org/D45006
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
