[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

This looks okay to me, but I think it would better if someone with more 
expertise in the design of the driver and frontend code could review this.



================
Comment at: lib/Driver/Driver.cpp:2267
+        if ((IA->getType() != types::TY_CUDA) &&
+            IA->getType() != types::TY_HIP) {
           // The builder will ignore this input.
----------------
The extra parens are weird here.


https://reviews.llvm.org/D45212



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits