george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.
Also I don't quite understand why being additive is important? Isn't pointer 
subtraction basically the same?



================
Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:78
 
+const Expr *peelOffPointerArithmetic(const BinaryOperator *B) {
+  if (B->isAdditiveOp() && B->getType()->isPointerType()) {
----------------
static.
+1 for using functions.


Repository:
  rC Clang

https://reviews.llvm.org/D45071



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to