[PATCH] D44552: [Coroutines] Find custom allocators in class scope

[Gor Nishanov via Phabricator via cfe-commits]

GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.

LGTM with some stylistic suggestions



================
Comment at: lib/Sema/SemaExprCXX.cpp:2351
+        return true;
+      else
+        LookupQualifiedName(R, Context.getTranslationUnitDecl());
----------------
drop else?

```
    if (R.empty()) {
      if (NewScope == AFS_Class)
        return true;

      LookupQualifiedName(R, Context.getTranslationUnitDecl());
    }
```


================
Comment at: lib/Sema/SemaExprCXX.cpp:2402
+      return true;
+    else {
+      DeclareGlobalNewDelete();
----------------
drop else? so that it will read:

```
  if (FoundDelete.empty()) {
    if (DeleteScope == AFS_Class)
      return true;

    DeclareGlobalNewDelete();
    LookupQualifiedName(FoundDelete, Context.getTranslationUnitDecl());
  }
```


Repository:
  rC Clang

https://reviews.llvm.org/D44552



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits