On 2018-03-27 01:47 PM, Reid Kleckner wrote: > One of these new tests does not pass on Windows due to assumptions about > absolute path structure. The FileCheck output seems self-explanatory: > > $ "FileCheck" "-strict-whitespace" > "C:\b\slave\clang-x86-windows-msvc2015\clang-x86-windows-msvc2015\llvm\tools\clang\tools\extra\test\clangd\textdocument-didchange-fail.test" > # command stderr: > C:\b\slave\clang-x86-windows-msvc2015\clang-x86-windows-msvc2015\llvm\tools\clang\tools\extra\test\clangd\textdocument-didchange-fail.test:22:20: > error: expected string not found in input > # CHECK-NEXT: "uri": "file:///clangd-test/main.cpp" > ^ > <stdin>:68:7: note: scanning from here > "uri": "file:///C%3a/clangd-test/main.cpp" > > I committed a speculative fix for this in r328645, hopefully it does the job.
Makes sense. Thanks for catching and fixing it! I received some failure notifications, but at first sight they seemed unrelated (maybe some of them were). I'll look more closely next time. Simon _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
