rjmccall added a comment.

LGTM.

If `__global__` is supported in C++ structures, you might also need to make 
sure that member function constants (`&A::kernel_function`) drop the CC.  And 
it might be a good idea to make sure that `decltype(kernel_function)` doesn't 
have a problem with it, either, since that does do some special-case work.



================
Comment at: lib/Sema/SemaExpr.cpp:1669
+    }
+  }
+
----------------
You should use `getAs<FunctionType>` here (no `const` necessary).  It's 
possible to declare a function with a typedef of function type, you just can't 
define it that way.


https://reviews.llvm.org/D44747



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to